Bug 135961 - Web Inspector: Add layout test for lowercase CSSProperty names
Summary: Web Inspector: Add layout test for lowercase CSSProperty names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-14 15:56 PDT by Matt Baker
Modified: 2014-09-08 17:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.77 KB, patch)
2014-08-14 17:05 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
Patch (8.01 KB, patch)
2014-08-15 17:13 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2014-08-14 15:56:29 PDT 
We need a test to ensure that CSSProperty.name is lowercase for author styles regardless of source CSS formatting.
Comment 1 Radar WebKit Bug Importer 2014-08-14 15:57:00 PDT 
<rdar://problem/18025282>
Comment 2 Matt Baker 2014-08-14 17:05:11 PDT 
Created attachment 236638 [details]
Patch
Comment 3 Timothy Hatcher 2014-08-15 08:06:25 PDT 
Comment on attachment 236638 [details]
Patch

Nice!
Comment 4 Joseph Pecoraro 2014-08-15 15:42:05 PDT 
Comment on attachment 236638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236638&action=review

> Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:86
> +        // CodeMirror is not included by Test.html, so skip MIME type associations.

This should be a generic comment. "CodeMirror is not included in tests, so skip MIME type associations.". The mention of Test.html is too specific and could go stale.

> LayoutTests/inspector/css/matched-style-properties.html:8
> +    BACKGROUND-COLOR:blue;
> +    COLOR:white;
> +    border-STYLE:solid;

Might as well test an all lower case, and wild camel case.

    position: absolute;
    ToP: 0;
    lEfT: 0;
Comment 5 Matt Baker 2014-08-15 17:13:55 PDT 
Created attachment 236694 [details]
Patch
Comment 6 Joseph Pecoraro 2014-08-26 16:49:39 PDT 
Comment on attachment 236694 [details]
Patch

Patch looks great. However tests are not being run at all?! We should really first unskip all inspector tests before landing this. Could you look into that?
Comment 7 WebKit Commit Bot 2014-09-08 17:00:45 PDT 
Comment on attachment 236694 [details]
Patch

Clearing flags on attachment: 236694

Committed r173406: <http://trac.webkit.org/changeset/173406>
Comment 8 WebKit Commit Bot 2014-09-08 17:00:48 PDT 
All reviewed patches have been landed.  Closing bug.