Bug 135961 – Web Inspector: Add layout test for lowercase CSSProperty names

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

We need a test to ensure that CSSProperty.name is lowercase for author styles regardless of source CSS formatting.

[Radar WebKit Bug Importer]

<rdar://problem/18025282>

[Matt Baker]

Created attachment 236638 [details]
Patch

[Timothy Hatcher]

Comment on attachment 236638 [details]
Patch

Nice!

[Joseph Pecoraro]

Comment on attachment 236638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236638&action=review

> Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:86
> +        // CodeMirror is not included by Test.html, so skip MIME type associations.

This should be a generic comment. "CodeMirror is not included in tests, so skip MIME type associations.". The mention of Test.html is too specific and could go stale.

> LayoutTests/inspector/css/matched-style-properties.html:8
> +    BACKGROUND-COLOR:blue;
> +    COLOR:white;
> +    border-STYLE:solid;

Might as well test an all lower case, and wild camel case.

    position: absolute;
    ToP: 0;
    lEfT: 0;

[Matt Baker]

Created attachment 236694 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 236694 [details]
Patch

Patch looks great. However tests are not being run at all?! We should really first unskip all inspector tests before landing this. Could you look into that?

[WebKit Commit Bot]

Comment on attachment 236694 [details]
Patch

Clearing flags on attachment: 236694

Committed r173406: <http://trac.webkit.org/changeset/173406>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.