Bug 135955 - Fixed a bmalloc crash seen on the EWS bot
Summary: Fixed a bmalloc crash seen on the EWS bot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-14 14:34 PDT by Geoffrey Garen
Modified: 2014-08-15 10:53 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2014-08-14 14:37 PDT, Geoffrey Garen
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2014-08-14 14:34:56 PDT
Fixed a bmalloc crash seen on the EWS bot
Comment 1 Geoffrey Garen 2014-08-14 14:37:13 PDT
Created attachment 236621 [details]
Patch
Comment 2 Geoffrey Garen 2014-08-14 14:40:03 PDT
Committed r172608: <http://trac.webkit.org/changeset/172608>
Comment 3 Csaba Osztrogonác 2014-08-15 02:11:29 PDT
(In reply to comment #2)
> Committed r172608: <http://trac.webkit.org/changeset/172608>

Maybe this change caused the issue on Apple Mac WK1 EWS bots:
https://lists.webkit.org/pipermail/webkit-dev/2014-August/026797.html

Could you check it?
Comment 4 Geoffrey Garen 2014-08-15 10:53:50 PDT
> (In reply to comment #2)
> > Committed r172608: <http://trac.webkit.org/changeset/172608>
> 
> Maybe this change caused the issue on Apple Mac WK1 EWS bots:
> https://lists.webkit.org/pipermail/webkit-dev/2014-August/026797.html
> 
> Could you check it?

This patch edited the SYSCALL macro, which is only used by bmalloc, which is disabled. (I just double-checked that there are no other clients of SYSCALL.) So, I think something else must have caused the failure.