Bug 135950 - Web Inspector: Dragging Undocked inspector by window title has broken behavior
Summary: Web Inspector: Dragging Undocked inspector by window title has broken behavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-14 13:57 PDT by Joseph Pecoraro
Modified: 2014-08-14 17:30 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Frontend Fix (3.18 KB, patch)
2014-08-14 15:34 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-08-14 13:57:22 PDT 
* SUMMARY
Dragging Undocked inspector by window title has broken behavior. Releasing the mouse does not stop the drag and can be completely broken. Also there is flickering.

* STEPS TO REPRODUCE
1. Inspect apple.com
2. Undock inspector if needed
3. Drag window vertically all the way to the top of the screen, release mouse
4. Try to mouse over the inspector window again
  => window goes bonkers
Comment 1 Radar WebKit Bug Importer 2014-08-14 13:57:30 PDT 
<rdar://problem/18023242>
Comment 2 Timothy Hatcher 2014-08-14 14:05:09 PDT 
Just the title or the whole title bar (22px) top? Do we need to draw our own title too? Sigh.
Comment 3 Joseph Pecoraro 2014-08-14 14:41:45 PDT 
(In reply to comment #2)
> Just the title or the whole title bar (22px) top? Do we need to draw our own title too? Sigh.

Just the top 22pt.
Comment 4 Timothy Hatcher 2014-08-14 14:43:14 PDT 
I wonder if both us and AppKit are trying to handle the drag.
Comment 5 Joseph Pecoraro 2014-08-14 15:34:34 PDT 
Created attachment 236628 [details]
[PATCH] Frontend Fix

Could probably use some more testing. I made sure that you could drag on exactly event.pageY 21, 22, 23, etc.
Comment 6 WebKit Commit Bot 2014-08-14 17:30:55 PDT 
Comment on attachment 236628 [details]
[PATCH] Frontend Fix

Clearing flags on attachment: 236628

Committed r172617: <http://trac.webkit.org/changeset/172617>
Comment 7 WebKit Commit Bot 2014-08-14 17:30:57 PDT 
All reviewed patches have been landed.  Closing bug.