Bug 135949 - Web Inspector: Avoid re-binding the same function over and over
Summary: Web Inspector: Avoid re-binding the same function over and over
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-14 12:59 PDT by Joseph Pecoraro
Modified: 2014-08-14 14:34 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.96 KB, patch)
2014-08-14 13:00 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-08-14 12:59:23 PDT 
* SUMMARY
During an auto capturing of pages, especially when doing the dead timeout check, we may be re-binding the same function hundreds of times. We should bind it once, it never changes. Possible performance issue.
Comment 1 Radar WebKit Bug Importer 2014-08-14 12:59:32 PDT 
<rdar://problem/18022467>
Comment 2 Joseph Pecoraro 2014-08-14 13:00:51 PDT 
Created attachment 236612 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2014-08-14 13:01:47 PDT 
For example reloading icloud.com this would happen over a thousand times.
Comment 4 WebKit Commit Bot 2014-08-14 14:34:51 PDT 
Comment on attachment 236612 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 236612

Committed r172606: <http://trac.webkit.org/changeset/172606>
Comment 5 WebKit Commit Bot 2014-08-14 14:34:53 PDT 
All reviewed patches have been landed.  Closing bug.