Bug 135941 - [Services with UI] Selection services don't work inside <iframes>
Summary: [Services with UI] Selection services don't work inside <iframes>
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrica Casucci
Keywords: InRadar
Depends on:
Reported: 2014-08-14 09:46 PDT by Enrica Casucci
Modified: 2014-08-14 11:37 PDT (History)
1 user (show)

See Also:

Test (155 bytes, text/html)
2014-08-14 09:46 PDT, Enrica Casucci
no flags Details
Patch (2.75 KB, patch)
2014-08-14 09:52 PDT, Enrica Casucci
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2014-08-14 09:46:35 PDT
Created attachment 236593 [details]

Use the attached test case.
Select something inside the iframe.
Hover to get the service UI.

EXPECTED: The service UI appears and you can click on the arrow.

ACTUAL: Nothing happens.

Comment 1 Enrica Casucci 2014-08-14 09:52:18 PDT
Created attachment 236595 [details]
Comment 2 Tim Horton 2014-08-14 10:53:55 PDT
Comment on attachment 236595 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=236595&action=review

> Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:524
> +    FrameView* viewForRange = selectionRange ? selectionRange->ownerDocument().view() : nullptr;

You dereference this inside the loop; should we just bail if !selectionRange instead?
Comment 3 Enrica Casucci 2014-08-14 11:37:55 PDT
Committed revision 172596.