Bug 135938 - Remove nonRendererStyle
Summary: Remove nonRendererStyle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-14 07:00 PDT by Antti Koivisto
Modified: 2014-08-14 10:52 PDT (History)
1 user (show)

See Also:


Attachments
patch (13.38 KB, patch)
2014-08-14 07:13 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-08-14 07:00:22 PDT
We should use computedStyle instead.
Comment 1 Antti Koivisto 2014-08-14 07:13:02 PDT
Created attachment 236588 [details]
patch
Comment 2 WebKit Commit Bot 2014-08-14 07:14:41 PDT
Attachment 236588 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Element.cpp:2865:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2014-08-14 10:24:46 PDT
Comment on attachment 236588 [details]
patch

r=me

Would be nice if we could allow style sharing for option and optgroup after this is fixed.
Comment 4 Antti Koivisto 2014-08-14 10:52:10 PDT
https://trac.webkit.org/r172591