Bug 135910 - run-webkit-tests should skip 'support' directories
Summary: run-webkit-tests should skip 'support' directories
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 135921
  Show dependency tree / graph
 
Reported: 2014-08-13 15:35 PDT by Rebecca Hauck
Modified: 2014-08-15 12:04 PDT (History)
4 users (show)

See Also:

Attachments
Patch for the bug (1.55 KB, patch)
2014-08-13 16:08 PDT, Rebecca Hauck 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rebecca Hauck 2014-08-13 15:35:21 PDT 
We explicitly skip a whole bunch of directories known to not contain any test files (reference, resources, etc.).  The W3C puts all support files in a directory named support, the runner should be updated to skip that, too so imported w3c tests needn't be modified.
Comment 1 Rebecca Hauck 2014-08-13 16:08:22 PDT 
Created attachment 236561 [details]
Patch for the bug
Comment 2 Bem Jones-Bey 2014-08-13 16:14:48 PDT 
r=me, we already have support directories in the tree, they just are lucky and don't contain anything that looks like a test.

I'd like to double check with Ryosuke before landing, though.
Comment 3 Ryosuke Niwa 2014-08-15 11:30:31 PDT 
Comment on attachment 236561 [details]
Patch for the bug

Looks great to me.
Comment 4 WebKit Commit Bot 2014-08-15 12:04:20 PDT 
Comment on attachment 236561 [details]
Patch for the bug

Clearing flags on attachment: 236561

Committed r172638: <http://trac.webkit.org/changeset/172638>
Comment 5 WebKit Commit Bot 2014-08-15 12:04:24 PDT 
All reviewed patches have been landed.  Closing bug.