WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
135910
run-webkit-tests should skip 'support' directories
https://bugs.webkit.org/show_bug.cgi?id=135910
Summary
run-webkit-tests should skip 'support' directories
Rebecca Hauck
Reported
2014-08-13 15:35:21 PDT
We explicitly skip a whole bunch of directories known to not contain any test files (reference, resources, etc.). The W3C puts all support files in a directory named support, the runner should be updated to skip that, too so imported w3c tests needn't be modified.
Attachments
Patch for the bug
(1.55 KB, patch)
2014-08-13 16:08 PDT
,
Rebecca Hauck
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Rebecca Hauck
Comment 1
2014-08-13 16:08:22 PDT
Created
attachment 236561
[details]
Patch for the bug
Bem Jones-Bey
Comment 2
2014-08-13 16:14:48 PDT
r=me, we already have support directories in the tree, they just are lucky and don't contain anything that looks like a test. I'd like to double check with Ryosuke before landing, though.
Ryosuke Niwa
Comment 3
2014-08-15 11:30:31 PDT
Comment on
attachment 236561
[details]
Patch for the bug Looks great to me.
WebKit Commit Bot
Comment 4
2014-08-15 12:04:20 PDT
Comment on
attachment 236561
[details]
Patch for the bug Clearing flags on attachment: 236561 Committed
r172638
: <
http://trac.webkit.org/changeset/172638
>
WebKit Commit Bot
Comment 5
2014-08-15 12:04:24 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug