Bug 135908 - Opening Web Inspector causes a large amount of sandbox violations
Summary: Opening Web Inspector causes a large amount of sandbox violations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-13 15:09 PDT by Joseph Pecoraro
Modified: 2014-08-13 15:31 PDT (History)
4 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (1.53 KB, patch)
2014-08-13 15:13 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-08-13 15:09:34 PDT
* SUMMARY
Opening Web Inspector causes a large amount of "deny file-issue-extension" sandbox violations:

>    com.apple.WebKit(93849) deny file-issue-extension /System/Library/PrivateFrameworks/WebInspectorUI.framework/Versions/A/Resources/Main.html
>    com.apple.WebKit(93849) deny file-issue-extension /System/Library/PrivateFrameworks/WebInspectorUI.framework/Versions/A/Resources/CodeMirror.css
>    com.apple.WebKit(93849) deny file-issue-extension /System/Library/PrivateFrameworks/WebInspectorUI.framework/Versions/A/Resources/Main.css
>    ...

* NOTES
This doesn't happen with local builds which does not use /S/L/PF/WebInspectorUI.framework but instead your own built WebInspectorUI.framework.

<rdar://problem/17998706>
Comment 1 Joseph Pecoraro 2014-08-13 15:13:05 PDT
Created attachment 236555 [details]
[PATCH] Proposed Fix
Comment 2 Timothy Hatcher 2014-08-13 15:17:03 PDT
Comment on attachment 236555 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=236555&action=review

> Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in:97
> +(allow-read-directory-and-issue-read-extensions "/System/Library/PrivateFrameworks/WebInspectorUI.framework")

Do we also need to add /System/Library/StagedFrameworks/Safari/WebInspectorUI.framework?
Comment 3 Alexey Proskuryakov 2014-08-13 15:20:41 PDT
r=me as well.

We shouldn't need StagedFrameworks, because WebInspectorUI.framework ends up being in the same directory as WebKit.framework, and thus the existing rule does the trick:

(allow-read-directory-and-issue-read-extensions (param "WEBKIT2_FRAMEWORK_DIR"))
Comment 4 WebKit Commit Bot 2014-08-13 15:31:03 PDT
Comment on attachment 236555 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 236555

Committed r172539: <http://trac.webkit.org/changeset/172539>
Comment 5 WebKit Commit Bot 2014-08-13 15:31:06 PDT
All reviewed patches have been landed.  Closing bug.