Bug 135898 - REGRESSION (r172326): Dashed/dotted borders do not paint.
Summary: REGRESSION (r172326): Dashed/dotted borders do not paint.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on: 135686
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-13 13:09 PDT by Joseph Pecoraro
Modified: 2015-01-05 20:42 PST (History)
10 users (show)

See Also:

Attachments
[TEST] Reduction (501 bytes, text/html)
2014-08-14 13:18 PDT, Joseph Pecoraro 		no flags Details
Patch (67.42 KB, patch)
2014-08-19 13:52 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (67.50 KB, patch)
2014-08-20 06:56 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-08-13 13:09:19 PDT 
* SUMMARY
Metrics pane is missing dashed borders.

Caused by:
<http://trac.webkit.org/changeset/172326>

* STEPS TO REPRODUCE
1. Inspect apple.com
2. Select <body> in DOM tree
3. Select Styles detail navigator in right sidebar
4. Select Metrics tab in Styles detail navigator
  => missing dashed borders (around the entire edge and between border and padding)

* NOTES
- devicePixelRatio = 1 on this machine
Comment 1 Radar WebKit Bug Importer 2014-08-13 13:09:28 PDT 
<rdar://problem/18009437>
Comment 2 Joseph Pecoraro 2014-08-14 13:18:53 PDT 
Created attachment 236613 [details]
[TEST] Reduction

Here is a simple reduction= showing the issue.
Comment 3 zalan 2014-08-19 13:52:15 PDT 
Created attachment 236822 [details]
Patch
Comment 4 Simon Fraser (smfr) 2014-08-19 13:56:22 PDT 
Comment on attachment 236822 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236822&action=review

> LayoutTests/fast/borders/border-painting-dashed-at-all-expected.html:19
> +  for (i = 1; i < 10; ++i) {

var i
Comment 5 zalan 2014-08-20 06:56:28 PDT 
Created attachment 236869 [details]
Patch
Comment 6 WebKit Commit Bot 2014-08-20 07:45:11 PDT 
Comment on attachment 236869 [details]
Patch

Clearing flags on attachment: 236869

Committed r172797: <http://trac.webkit.org/changeset/172797>
Comment 7 WebKit Commit Bot 2014-08-20 07:45:14 PDT 
All reviewed patches have been landed.  Closing bug.