Bug 135888 - enable llint on Windows CMake build
Summary: enable llint on Windows CMake build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-13 10:41 PDT by Alex Christensen
Modified: 2014-08-19 10:37 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.71 KB, patch)
2014-08-13 10:47 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-08-13 10:41:42 PDT 
Windows puts assembly in a separate file instead of LLIntAssembly.h because of string length limits (2^16-1) in Visual Studio.  The CMake build needs to be tweaked to do this, too.
Comment 1 Alex Christensen 2014-08-13 10:47:11 PDT 
Created attachment 236534 [details]
Patch
Comment 2 Brent Fulgham 2014-08-18 14:45:40 PDT 
Comment on attachment 236534 [details]
Patch

Looks good to me, too.
Comment 3 WebKit Commit Bot 2014-08-19 10:37:13 PDT 
Comment on attachment 236534 [details]
Patch

Clearing flags on attachment: 236534

Committed r172754: <http://trac.webkit.org/changeset/172754>
Comment 4 WebKit Commit Bot 2014-08-19 10:37:17 PDT 
All reviewed patches have been landed.  Closing bug.