Bug 135884 – [EFL] Introduce DEVELOPER_MODE

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

Like GTK port, DEVELOPER_MODE can be good solution for developing, debugging and testing instead of SHARED_CORE.
SHARED_CORE can reduce link time and memory consumption but it is slightly different from release binary.

[Ryuan Choi]

Created attachment 236530 [details]
Patch

[Laszlo Gombos]

Comment on attachment 236530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236530&action=review

> Source/cmake/OptionsEfl.cmake:301
> +    if (CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")

Is this compiler check necessary here ? Which other compilers are supported ?

[Ryuan Choi]

Created attachment 236570 [details]
Patch

[Ryuan Choi]

(In reply to comment #2)
> (From update of attachment 236530 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236530&action=review
> 
> > Source/cmake/OptionsEfl.cmake:301
> > +    if (CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
> 
> Is this compiler check necessary here ? Which other compilers are supported ?

No, at least now.

I removed it.

[Gyuyoung Kim]

Comment on attachment 236570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236570&action=review

> Tools/Scripts/webkitdirs.pm:1944
>      # GTK+ has a production mode, but build-webkit should always use developer mode.

According to this comment, gtk port looks have a production mode. So, they set developer mode as default. However, do we have production mode as gtk port ?

[Gyuyoung Kim]

Comment on attachment 236570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236570&action=review

> Source/cmake/OptionsEfl.cmake:50
>  set(VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/eflsymbols.filter")

I think we need to move this line into 60 line, because this is no meaning when DEVELOPER_MODE is ON.

[Gyuyoung Kim]

Comment on attachment 236570 [details]
Patch

Please land this patch after fixing my comment. r=me.

[Gyuyoung Kim]

(In reply to comment #7)
> (From update of attachment 236570 [details])
> Please land this patch after fixing my comment. r=me.

Ryuan, I want to land this patch in order not to use SHARED_CORE anymore. Please land this patch after fixing my comment !!!!

[Ryuan Choi]

Committed r172894: <http://trac.webkit.org/changeset/172894>

[Ryuan Choi]

Comment on attachment 236570 [details]
Patch

landed manually after followed gyuyoung's comment