Bug 135884 - [EFL] Introduce DEVELOPER_MODE
Summary: [EFL] Introduce DEVELOPER_MODE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks: 80683
  Show dependency treegraph
 
Reported: 2014-08-13 09:28 PDT by Ryuan Choi
Modified: 2014-08-24 22:47 PDT (History)
8 users (show)

See Also:


Attachments
Patch (4.78 KB, patch)
2014-08-13 09:31 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff
Patch (4.68 KB, patch)
2014-08-13 17:33 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2014-08-13 09:28:16 PDT
Like GTK port, DEVELOPER_MODE can be good solution for developing, debugging and testing instead of SHARED_CORE.
SHARED_CORE can reduce link time and memory consumption but it is slightly different from release binary.
Comment 1 Ryuan Choi 2014-08-13 09:31:52 PDT
Created attachment 236530 [details]
Patch
Comment 2 Laszlo Gombos 2014-08-13 11:19:04 PDT
Comment on attachment 236530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236530&action=review

> Source/cmake/OptionsEfl.cmake:301
> +    if (CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")

Is this compiler check necessary here ? Which other compilers are supported ?
Comment 3 Ryuan Choi 2014-08-13 17:33:51 PDT
Created attachment 236570 [details]
Patch
Comment 4 Ryuan Choi 2014-08-13 17:34:14 PDT
(In reply to comment #2)
> (From update of attachment 236530 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236530&action=review
> 
> > Source/cmake/OptionsEfl.cmake:301
> > +    if (CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
> 
> Is this compiler check necessary here ? Which other compilers are supported ?

No, at least now.

I removed it.
Comment 5 Gyuyoung Kim 2014-08-13 18:51:00 PDT
Comment on attachment 236570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236570&action=review

> Tools/Scripts/webkitdirs.pm:1944
>      # GTK+ has a production mode, but build-webkit should always use developer mode.

According to this comment, gtk port looks have a production mode. So, they set developer mode as default. However, do we have production mode as gtk port ?
Comment 6 Gyuyoung Kim 2014-08-21 23:04:17 PDT
Comment on attachment 236570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236570&action=review

> Source/cmake/OptionsEfl.cmake:50
>  set(VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/eflsymbols.filter")

I think we need to move this line into 60 line, because this is no meaning when DEVELOPER_MODE is ON.
Comment 7 Gyuyoung Kim 2014-08-22 02:56:52 PDT
Comment on attachment 236570 [details]
Patch

Please land this patch after fixing my comment. r=me.
Comment 8 Gyuyoung Kim 2014-08-22 23:08:46 PDT
(In reply to comment #7)
> (From update of attachment 236570 [details])
> Please land this patch after fixing my comment. r=me.

Ryuan, I want to land this patch in order not to use SHARED_CORE anymore. Please land this patch after fixing my comment !!!!
Comment 9 Ryuan Choi 2014-08-24 02:13:32 PDT
Committed r172894: <http://trac.webkit.org/changeset/172894>
Comment 10 Ryuan Choi 2014-08-24 04:26:20 PDT
Comment on attachment 236570 [details]
Patch

landed manually after followed gyuyoung's comment