RESOLVED FIXED 135862
remove plugins/mac 
https://bugs.webkit.org/show_bug.cgi?id=135862
Summary remove plugins/mac
Alex Christensen
Reported 2014-08-12 15:53:35 PDT
plugins/mac seems to have dead code. It is not built by Xcode. Let's get rid of it.
Attachments
Patch (32.90 KB, patch)
2014-08-12 15:56 PDT, Alex Christensen 		ap: review+
achristensen: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2014-08-12 15:56:00 PDT
Created attachment 236477 [details] Patch
Alexey Proskuryakov
Comment 2 2014-08-12 19:13:12 PDT
Are these files built when building 32-bit? They might be excluded from 64-bit build, because it doesn't support in-process plug-ins.
Alex Christensen
Comment 3 2014-08-12 21:05:34 PDT
I don't think so. Grepping for PluginPackageMac.cpp shows it's only referenced in CMake files (which I added by mistake) and ChangeLogs. If it were built, wouldn't it be in the Xcode files?
Alexey Proskuryakov
Comment 4 2014-08-12 22:27:41 PDT
Comment on attachment 236477 [details] Patch Fun, seems like these were only used by Qt on Mac. Looks like there are other unused files in WebCore/plugins (I found PluginDataNone.cpp).
Alex Christensen
Comment 5 2014-08-12 23:29:36 PDT
Comment on attachment 236477 [details] Patch I'll look into this tomorrow.
Alex Christensen
Comment 6 2014-08-13 13:42:36 PDT
Removed PluginDataNone.cpp, too, and mentioned in the committed change log. http://trac.webkit.org/changeset/172535
Note You need to log in before you can comment on or make changes to this bug.