Bug 135862 - remove plugins/mac
Summary: remove plugins/mac
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Depends on:
Reported: 2014-08-12 15:53 PDT by Alex Christensen
Modified: 2014-08-13 13:42 PDT (History)
3 users (show)

See Also:

Patch (32.90 KB, patch)
2014-08-12 15:56 PDT, Alex Christensen
ap: review+
achristensen: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-08-12 15:53:35 PDT
plugins/mac seems to have dead code.  It is not built by Xcode.  Let's get rid of it.
Comment 1 Alex Christensen 2014-08-12 15:56:00 PDT
Created attachment 236477 [details]
Comment 2 Alexey Proskuryakov 2014-08-12 19:13:12 PDT
Are these files built when building 32-bit? They might be excluded from 64-bit build, because it doesn't support in-process plug-ins.
Comment 3 Alex Christensen 2014-08-12 21:05:34 PDT
I don't think so.  Grepping for PluginPackageMac.cpp shows it's only referenced in CMake files (which I added by mistake) and ChangeLogs.  If it were built, wouldn't it be in the Xcode files?
Comment 4 Alexey Proskuryakov 2014-08-12 22:27:41 PDT
Comment on attachment 236477 [details]

Fun, seems like these were only used by Qt on Mac. Looks like there are other unused files in WebCore/plugins (I found PluginDataNone.cpp).
Comment 5 Alex Christensen 2014-08-12 23:29:36 PDT
Comment on attachment 236477 [details]

I'll look into this tomorrow.
Comment 6 Alex Christensen 2014-08-13 13:42:36 PDT
Removed PluginDataNone.cpp, too, and mentioned in the committed change log.