Bug 135849 - Web Inspector: Timeline selection range creation does not work when clicking event bubble or near bottom of overview
Summary: Web Inspector: Timeline selection range creation does not work when clicking ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-12 12:46 PDT by Joseph Pecoraro
Modified: 2014-08-12 13:44 PDT (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (1.54 KB, patch)
2014-08-12 12:53 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-08-12 12:46:03 PDT
* SUMMARY
Timeline selection range creation does not work when clicking event bubble or near bottom of overview. Click and drag should always work.

* STEPS TO REPRODUCe
1. Inspect apple.com
2. Reload to get timeline data
3. Switch to Timelines view
4. Zoom in on overview so there are some script/layout blocks that are not tiny
5. Attempt to start a new selection on an event bubble
  => does not work
6. Attempt to start a new selection anywhere near the bottom of the overview
  => does not work
Comment 1 Radar WebKit Bug Importer 2014-08-12 12:46:24 PDT
<rdar://problem/17994473>
Comment 2 Joseph Pecoraro 2014-08-12 12:50:14 PDT
Seems the issue is that the .timeline-ruler region is not involved with the event bubble chain when clicking something in the sibling graph-container region. At the bottom of the view, the scroller with its height of 16px is nabbing the mouse events.

Giving the timeline ruler a z-index fixes all the issues. I wonder if there might be a better way.
Comment 3 Joseph Pecoraro 2014-08-12 12:53:44 PDT
Created attachment 236461 [details]
[PATCH] Proposed Fix
Comment 4 WebKit Commit Bot 2014-08-12 13:43:58 PDT
Comment on attachment 236461 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 236461

Committed r172488: <http://trac.webkit.org/changeset/172488>
Comment 5 WebKit Commit Bot 2014-08-12 13:44:01 PDT
All reviewed patches have been landed.  Closing bug.