Bug 135845 - [iOS] build-webkit should not build WebKitSystemInterface and WebKitAdditions
Summary: [iOS] build-webkit should not build WebKitSystemInterface and WebKitAdditions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-12 11:10 PDT by Daniel Bates
Modified: 2014-08-12 19:35 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.80 KB, patch)
2014-08-12 11:15 PDT, Daniel Bates 		aestes: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-08-12 11:10:22 PDT 
We should remove the logic added to build-webkit to build projects WebKitSystemInterface and WebKitAdditions when building the iOS WebKit port because build-webkit shouldn't be responsible for building such projects. Such logic was added as a convenience to expedite the bring up of the iOS WebKit port when it was upstreamed.
Comment 1 Daniel Bates 2014-08-12 11:14:58 PDT 
Removing the dependencies to build projects WebKitSystemInterface and WebKitAdditions when building the iOS WebKit port will help towards building the iOS WebKit port using the public SDK.
Comment 2 Daniel Bates 2014-08-12 11:15:54 PDT 
Created attachment 236456 [details]
Patch
Comment 3 Daniel Bates 2014-08-12 19:35:53 PDT 
Committed r172511: <http://trac.webkit.org/changeset/172511>