Bug 135843 - BPLATFORM(IOS) always evaluates to false
Summary: BPLATFORM(IOS) always evaluates to false
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
Depends on:
Blocks: 135848
  Show dependency treegraph
Reported: 2014-08-12 10:10 PDT by Daniel Bates
Modified: 2014-08-12 19:33 PDT (History)
5 users (show)

See Also:

Patch (1.55 KB, patch)
2014-08-12 10:11 PDT, Daniel Bates
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-08-12 10:10:16 PDT
BPLATFORM(IOS) always evaluates to false regardless of whether we are building bmalloc for iOS. Moreover, BPLATFORM(X) always evaluates to false for any X.
Comment 1 Daniel Bates 2014-08-12 10:11:44 PDT
Created attachment 236452 [details]
Comment 2 Daniel Bates 2014-08-12 10:20:33 PDT
The patch for bug #131658 defined BPLATFORM(X) as (defined BPLATFORM_##PLATFORM && PLATFORM_##PLATFORM).

Notice that the second conjunct is PLATFORM_##PLATFORM. But it should be BPLATFORM_##PLATFORM. Otherwise BPLATFORM(X) will always evaluate to false for any X since PLATFORM_X is undefined for any X and an undefined macro value evaluates to false in a boolean context.
Comment 3 Geoffrey Garen 2014-08-12 12:45:37 PDT
Comment on attachment 236452 [details]

Comment 4 Daniel Bates 2014-08-12 19:27:48 PDT
For completeness, with the proposed change iOS will use 16kB pages instead of 4kb pages.
Comment 5 Daniel Bates 2014-08-12 19:33:25 PDT
Committed r172510: <http://trac.webkit.org/changeset/172510>