Bug 135832 - [CMAKE] WebProcess shouldn't need to explicitly link to JavaScriptCore and WebCore
Summary: [CMAKE] WebProcess shouldn't need to explicitly link to JavaScriptCore and We...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2014-08-12 00:43 PDT by Carlos Garcia Campos
Modified: 2014-08-12 23:44 PDT (History)
8 users (show)

See Also:

Attachments
Patch (950 bytes, patch)
2014-08-12 00:45 PDT, Carlos Garcia Campos 		gyuyoung.kim: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-08-12 00:43:19 PDT 
Linking to WebKit2 should be enough, like Network and Plugin processes.
Comment 1 Carlos Garcia Campos 2014-08-12 00:45:49 PDT 
Created attachment 236430 [details]
Patch

Gyuyoung, could you please confirm this patch doesn't break the EFL build with shared WebCore?
Comment 2 Ryuan Choi 2014-08-12 16:50:45 PDT 
I don't remember why it was required long time ago.

But I can confirm that EFL port looks fine now with this patch whatever SHARED_CORE is ON/OFF.
Comment 3 Gyuyoung Kim 2014-08-12 22:38:11 PDT 
(In reply to comment #1)
> Created an attachment (id=236430) [details]
> Patch
> 
> Gyuyoung, could you please confirm this patch doesn't break the EFL build with shared WebCore?

When I test this patch locally, there is no build break. Besides I let efl-ews to build with SHARED_CORE=ON yesterday.

Additionally I'm taking a look how to run layout test on EFL port regardless of SHARED_CORE.
Comment 4 Gyuyoung Kim 2014-08-12 22:42:44 PDT 
(In reply to comment #2)
> I don't remember why it was required long time ago.

IIRC, initial EFL WK1 DumpRenderTree was implemented only with SHARED_CORE=ON because SAHRED_CORE reduces linking time on debug build. It looks nobody checked EFL layout test failed on release build at that time. IMO, that's why EFL port should enable SHARED_CORE to run layout test. However, it looks EFL WK2 doesn't need to enable it if we set something environment variables. Let me post when I solve this issue.
Comment 5 Carlos Garcia Campos 2014-08-12 23:44:59 PDT 
Committed r172516: <http://trac.webkit.org/changeset/172516>