Bug 135807 - generate header detection files on Windows CMake
Summary: generate header detection files on Windows CMake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-11 10:59 PDT by Alex Christensen
Modified: 2014-08-12 15:44 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.74 KB, patch)
2014-08-11 11:03 PDT, Alex Christensen 		bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-08-11 10:59:42 PDT 
The Windows build requires WTF/WTFHeaderDetection.h and WebCore/WebCoreHeaderDetection.h, which are generated by testing for the existence of Apple internal stuff.  I've implemented the stubs of these headers to get them to compile without detecting the internal stuff, which will need to be done later.
Comment 1 Alex Christensen 2014-08-11 11:03:08 PDT 
Created attachment 236383 [details]
Patch
Comment 2 Brent Fulgham 2014-08-12 14:32:37 PDT 
Comment on attachment 236383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236383&action=review

r=me. Please change those bugs to be "FIXME(Bug ###)" format, with bugs filed to extend the CMake stuff to do what we need for internal use.

> Source/WTF/wtf/PlatformWin.cmake:22
> +#FIXME: This should run testOSXLevel.cmd if it is available.

Please file a bug and make this a #FIXME(Bug##) bug.

> Source/WebCore/PlatformWin.cmake:93
> +#FIXME: This should test if AVF headers are available.

Ditto above comment.
Comment 3 Alex Christensen 2014-08-12 15:44:00 PDT 
Added comments and committed to http://trac.webkit.org/changeset/172499