Bug 135781 – Refactor ShapeOutsideInfo so it isn't mutated for each line

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Bem Jones-Bey]

Refactor ShapeOutsideInfo so it isn't mutated for each line

[Bem Jones-Bey]

Created attachment 236327 [details]
Patch

[Bem Jones-Bey]

Created attachment 236330 [details]
Patch

Rebased so it will actually apply.

[Bem Jones-Bey]

Created attachment 236454 [details]
Patch

Rearrange bool members of ShapeOutsideDeltas to get more efficient layout.

[Zoltan Horvath]

Comment on attachment 236454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236454&action=review

> Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:336
> +        return m_shapeOutsideDeltas;

You don't need this return.

[Bem Jones-Bey]

Comment on attachment 236454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236454&action=review

>> Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:336
>> +        return m_shapeOutsideDeltas;
> 
> You don't need this return.

You're right. I'll fix that.

[Bem Jones-Bey]

Created attachment 236462 [details]
Patch

Remove extra return statement

[Zoltan Horvath]

Comment on attachment 236462 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236462&action=review

r=me

> Source/WebCore/rendering/shapes/ShapeOutsideInfo.h:47
> +    WTF_MAKE_FAST_ALLOCATED;

Since ShapeOutsideDeltas isn't instantiated by operator new, you don't need to make it fast allocated.

[Bem Jones-Bey]

Created attachment 236538 [details]
Patch

Remove unneeded fast allocation for ShapeOutsideDeltas

[WebKit Commit Bot]

Comment on attachment 236538 [details]
Patch

Clearing flags on attachment: 236538

Committed r172529: <http://trac.webkit.org/changeset/172529>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.