Load the layout test result image diff HTML from a file, rather than having it inline in webkitpy
Created attachment 236326 [details] Patch
Comment on attachment 236326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236326&action=review > LayoutTests/fast/harness/image-diff-template.html:15 > +var preloadedImageCount = 0; indentationplz > LayoutTests/fast/harness/image-diff-template.html:26 > +image.addEventListener('load', preloadComplete); here too
Comment on attachment 236326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236326&action=review > Tools/ChangeLog:8 > + Pull the HTML the image diff file into a separate file, for easier hackability. This sentence doesn't read well.
Comment on attachment 236326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236326&action=review > LayoutTests/fast/harness/image-diff-template.html:10 > +<div class=imageText></div> > +<div class=imageContainer data-prefix="%(prefix)s">Loading...</div> Nit: I know you are just copying and pasting this markup. We should add quotes are the value of the HTML class attribute.
(In reply to comment #4) > (From update of attachment 236326 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236326&action=review > > > LayoutTests/fast/harness/image-diff-template.html:10 > > +<div class=imageText></div> > > +<div class=imageContainer data-prefix="%(prefix)s">Loading...</div> > > Nit: [...] We should add quotes are the value of the HTML class attribute. * We should add quotes around the value of the HTML class attribute.
https://trac.webkit.org/r172368