* STEPS TO REPRODUCE 0. Install and enable a text viewer extension. 1. Load the Yelp page for Nihon Whiskey Loung in San Francisco - http://www.yelp.com/biz/nihon-whisky-lounge-san-francisco#query:nihon%20whiskey%20lounge 2. Select text from the second review, then hover over the first line of the selection. 3. Nothing happens - no arrow. 4. Hover a bit lower, over the whitespace under the first line. 5. Arrow appears. <rdar://problem/17837670>
Created attachment 236322 [details] Patch
Comment on attachment 236322 [details] Patch I stared at the rect math for like 5 minutes. Seems fine!
Comment on attachment 236322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236322&action=review > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:152 > + if (rects.isEmpty() || rects.size() == 1) should this just be rects.size() <= 1? > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:171 > + // Next stich together all the rects on the last line of the selection. s/stich/stitch/ > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:186 > + // indexFromEnd is the index of the last rectangle on the sendon the last line. "on the sendon"?
(In reply to comment #3) > (From update of attachment 236322 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236322&action=review > > > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:152 > > + if (rects.isEmpty() || rects.size() == 1) > > should this just be rects.size() <= 1? Yes, it is better. > > > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:171 > > + // Next stich together all the rects on the last line of the selection. > > s/stich/stitch/ > > > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:186 > > + // indexFromEnd is the index of the last rectangle on the sendon the last line. > > "on the sendon"? Thanks for catching the typos.
Committed revision 172395.