Bug 135770 - [CSS Grid Layout] Test coverage for first-line pseudo-element
Summary: [CSS Grid Layout] Test coverage for first-line pseudo-element
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
Depends on:
Blocks: 60731
  Show dependency treegraph
Reported: 2014-08-08 14:44 PDT by Manuel Rego Casasnovas
Modified: 2014-09-02 01:36 PDT (History)
3 users (show)

See Also:

Patch (5.52 KB, patch)
2014-08-08 14:48 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2014-08-08 14:44:21 PDT
According to the spec the ::first-line pseudo-element do not apply to grid containers:
"the ::first-line and ::first-letter pseudo-elements do not apply to grid containers."

I'll provide a patch to add coverage for ::first-line which is already working as expected.
::first-letter needs some changes in the code, so it'd be done in a separated patch.

This has already landed in Blink: https://src.chromium.org/viewvc/blink?view=rev&revision=179640
Comment 1 Manuel Rego Casasnovas 2014-08-08 14:48:37 PDT
Created attachment 236309 [details]
Comment 2 Zoltan Horvath 2014-08-13 11:20:14 PDT
Comment on attachment 236309 [details]

Comment 3 WebKit Commit Bot 2014-09-02 01:36:25 PDT
Comment on attachment 236309 [details]

Clearing flags on attachment: 236309

Committed r173169: <http://trac.webkit.org/changeset/173169>
Comment 4 WebKit Commit Bot 2014-09-02 01:36:27 PDT
All reviewed patches have been landed.  Closing bug.