Bug 135759 – Adjustments to CueBox CSS Width calculations

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Roger Fong]

<rdar://problem/17954473>

This is a followup patch to http://trac.webkit.org/changeset/172224

It addresses the bugs I introduced with that revision and fixes the two test failures skipped here:
https://bugs.webkit.org/show_bug.cgi?id=135720

[Roger Fong]

Created attachment 236293 [details]
patch

[Eric Carlson]

Comment on attachment 236293 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236293&action=review

r=me with a few nits.

Thanks!

> Source/WebCore/html/shadow/MediaControlElements.cpp:1243
> +        toVTTCue(cue)->shouldChange();

The call to setFontSize should set m_displayTreeShouldChange automatically.

> Source/WebCore/html/track/TextTrackCueGeneric.cpp:87
> +            setInlineStyleProperty(CSSPropertyWidth, std::min(size * multiplier, 100.0f), CSSPrimitiveValue::CSS_PERCENTAGE);

Nit:The "f" isn't necessary, "100.0" should be sufficient.

> Source/WebCore/html/track/TextTrackCueGeneric.cpp:89
> +            setInlineStyleProperty(CSSPropertyHeight, std::min(size * multiplier, 100.0f),  CSSPrimitiveValue::CSS_PERCENTAGE);

Ditto.

> Source/WebCore/html/track/VTTCue.cpp:176
> +        setInlineStyleProperty(CSSPropertyWidth, std::min(static_cast<float>(m_cue.getCSSSize() * multiplier), 100.0f), CSSPrimitiveValue::CSS_PERCENTAGE);

Ditto.

> Source/WebCore/html/track/VTTCue.cpp:184
> +        setInlineStyleProperty(CSSPropertyMaxHeight, 100.0 - position.second, CSSPrimitiveValue::CSS_PERCENTAGE);

Ditto.

[Roger Fong]

Landed: http://trac.webkit.org/changeset/172351

[Alexey Proskuryakov]

*** Bug 135720 has been marked as a duplicate of this bug. ***