Bug 135755 - Services overlay dropdown is often in the wrong place with zoomed pages or horizontal scrolling
Summary: Services overlay dropdown is often in the wrong place with zoomed pages or ho...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-08 02:53 PDT by Tim Horton
Modified: 2014-08-08 09:23 PDT (History)
2 users (show)

See Also:

Attachments
patch (3.38 KB, patch)
2014-08-08 02:56 PDT, Tim Horton 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-08-08 02:53:42 PDT 
DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection adjust the location of the button based on the visible rect, trying to keep the button visible.

We're handing it the wrong visible rect, though, not taking scrolling into account.

This leads to pages that scroll horizontally showing the button on the left even if there's space for it on the right, or sometimes not showing it at all.

<rdar://problem/17907752>
Comment 1 Tim Horton 2014-08-08 02:56:03 PDT 
Created attachment 236275 [details]
patch
Comment 2 Tim Horton 2014-08-08 09:23:05 PDT 
http://trac.webkit.org/changeset/172344