Bug 135751 - [WebAudio] FFTFrame is cluttered with dead code
Summary: [WebAudio] FFTFrame is cluttered with dead code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-08 00:55 PDT by Philippe Normand
Modified: 2014-08-12 00:50 PDT (History)
8 users (show)

See Also:


Attachments
Patch (25.12 KB, patch)
2014-08-11 00:34 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff
Patch (25.74 KB, patch)
2014-08-11 02:13 PDT, Philippe Normand
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2014-08-08 00:55:54 PDT
There are currently 4 FFTFrame implementations but I think that only 2 are used, the one for Mac and the GStreamer implementation.

FFTFrame.h has also some ifdefs WEBAUDIO_OPENMAX_DL_FFT which were specific to Chromium, I think we should remove this.

Thoughts?
Comment 1 Eric Carlson 2014-08-08 08:43:15 PDT
(In reply to comment #0)
> There are currently 4 FFTFrame implementations but I think that only 2 are used, the one for Mac and the GStreamer implementation.
> 
> FFTFrame.h has also some ifdefs WEBAUDIO_OPENMAX_DL_FFT which were specific to Chromium, I think we should remove this.
> 
> Thoughts?

Out with the old and unused!
Comment 2 Philippe Normand 2014-08-08 09:08:58 PDT
Ok, I'm too busy now but I'll prepare a patch next week.
Comment 3 Philippe Normand 2014-08-11 00:34:49 PDT
Created attachment 236354 [details]
Patch
Comment 4 Philippe Normand 2014-08-11 02:13:03 PDT
Created attachment 236359 [details]
Patch

Also removing unused ifdefs from AudioArray.h
Comment 5 Eric Carlson 2014-08-11 06:52:39 PDT
Comment on attachment 236359 [details]
Patch

Thanks Philippe!
Comment 6 Philippe Normand 2014-08-12 00:50:09 PDT
Committed r172431: <http://trac.webkit.org/changeset/172431>