WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
135746
Web Inspector: add a Scripts timeline record for Promise fulfillment
https://bugs.webkit.org/show_bug.cgi?id=135746
Summary
Web Inspector: add a Scripts timeline record for Promise fulfillment
Brian Burg
Reported
2014-08-07 22:28:46 PDT
This will require new instrumentation. It should be like Timer Fired, except more promising. It should be simple to also include whether the promise was resolved or rejected. Sometimes, it doesn't quite work the way people expect.. :)
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2014-08-07 22:29:23 PDT
<
rdar://problem/17956025
>
Brian Burg
Comment 2
2014-08-08 23:24:17 PDT
I am not sure how we would get these callbacks through to an inspector agent. Current paths include plumbing to call into the global object's JSGlobalObjectInspectorController (i.e, to report exceptions) and through ScriptDebugServer listeners. The former seems better here, but that controller is guarded by ENABLE(REMOTE_INSPECTOR). Any thoughts, Joe?
Joseph Pecoraro
Comment 3
2014-08-11 11:29:12 PDT
(In reply to
comment #2
)
> I am not sure how we would get these callbacks through to an inspector agent. Current paths include plumbing to call into the global object's JSGlobalObjectInspectorController (i.e, to report exceptions) and through ScriptDebugServer listeners. The former seems better here, but that controller is guarded by ENABLE(REMOTE_INSPECTOR).
JSGlobalObjectInspectorController is only for JSContext inspection. I think this should go through the JSGlobalObject::debugger JSC::Debugger (ScriptDebugServer).
Joseph Pecoraro
Comment 4
2016-07-22 20:05:08 PDT
We did this with ScriptProfiler's Event records. Promise fulfillment is a Microtask event, and we have bubbles and profiling data for these evaluations.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug