RESOLVED FIXED 135745
Web Inspector: breakpoints enabled state is not persisted across re-opening the inspector 
https://bugs.webkit.org/show_bug.cgi?id=135745
Summary Web Inspector: breakpoints enabled state is not persisted across re-opening t...
Brian Burg
Reported 2014-08-07 21:50:30 PDT
My hunch is that we force this setting to be on when we restore breakpoints. In DebuggerManager.setBreakpoint, it unconditionally enables breakpoints when they are set, to avoid the situation where the user sets a breakpoint and nothing happens. However, in this case the user isn't doing anything, so no need to dummy-proof it.
Attachments
[PATCH] Proposed Fix (2.38 KB, patch)
2014-08-07 22:04 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-08-07 21:51:11 PDT
<rdar://problem/17955768>
Joseph Pecoraro
Comment 2 2014-08-07 21:55:49 PDT
* STEPS TO REPRODUCE 1. Open inspector 2. Disable breakpoints 3. Close Inspector 4. Open Inspector => breakpoints should be disabled, but they are enabled
Joseph Pecoraro
Comment 3 2014-08-07 22:04:48 PDT
Created attachment 236265 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 4 2014-08-07 23:53:44 PDT
Comment on attachment 236265 [details] [PATCH] Proposed Fix Clearing flags on attachment: 236265 Committed r172333: <http://trac.webkit.org/changeset/172333>
WebKit Commit Bot
Comment 5 2014-08-07 23:53:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.