Bug 135745 - Web Inspector: breakpoints enabled state is not persisted across re-opening the inspector
Summary: Web Inspector: breakpoints enabled state is not persisted across re-opening t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-07 21:50 PDT by Brian Burg
Modified: 2014-08-07 23:53 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.38 KB, patch)
2014-08-07 22:04 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-08-07 21:50:30 PDT 
My hunch is that we force this setting to be on when we restore breakpoints. In DebuggerManager.setBreakpoint, it unconditionally enables breakpoints when they are set, to avoid the situation where the user sets a breakpoint and nothing happens. However, in this case the user isn't doing anything, so no need to dummy-proof it.
Comment 1 Radar WebKit Bug Importer 2014-08-07 21:51:11 PDT 
<rdar://problem/17955768>
Comment 2 Joseph Pecoraro 2014-08-07 21:55:49 PDT 
* STEPS TO REPRODUCE
1. Open inspector
2. Disable breakpoints
3. Close Inspector
4. Open Inspector
  => breakpoints should be disabled, but they are enabled
Comment 3 Joseph Pecoraro 2014-08-07 22:04:48 PDT 
Created attachment 236265 [details]
[PATCH] Proposed Fix
Comment 4 WebKit Commit Bot 2014-08-07 23:53:44 PDT 
Comment on attachment 236265 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 236265

Committed r172333: <http://trac.webkit.org/changeset/172333>
Comment 5 WebKit Commit Bot 2014-08-07 23:53:46 PDT 
All reviewed patches have been landed.  Closing bug.