RESOLVED FIXED 135744
commit-log-message has extra blank line at the top of pre-populated message 
https://bugs.webkit.org/show_bug.cgi?id=135744
Summary commit-log-message has extra blank line at the top of pre-populated message
Joseph Pecoraro
Reported 2014-08-07 21:35:10 PDT
* SUMMARY commit-log-message has extra blank line at the top of pre-populated message. * NOTES Caused by: <https://webkit.org/b/131727> Fix the commit-log-editor after r167243 and add more unit tests My work flow is something like: 1. Make change 2. git add files 3. prepare-ChangeLog --git-index 4. git add ChangeLogs 5. git commit => extra newline
Attachments
[PATCH] Proposed Fix (3.26 KB, patch)
2014-08-07 21:51 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-08-07 21:41:13 PDT
In my case, I have a single ChangeLog entry, so the $commonPrefix is empty. The extra newline gets added because of: > if (!$commonPrefix) { > push @result, normalizeLineEndings("\n", $endl); > }
Joseph Pecoraro
Comment 2 2014-08-07 21:51:18 PDT
Created attachment 236264 [details] [PATCH] Proposed Fix
Csaba Osztrogonác
Comment 3 2014-08-08 00:36:37 PDT
Comment on attachment 236264 [details] [PATCH] Proposed Fix Sorry for the trouble and thanks for the fix. r=me.
WebKit Commit Bot
Comment 4 2014-08-08 01:09:27 PDT
Comment on attachment 236264 [details] [PATCH] Proposed Fix Clearing flags on attachment: 236264 Committed r172339: <http://trac.webkit.org/changeset/172339>
WebKit Commit Bot
Comment 5 2014-08-08 01:09:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.