Bug 135743 – Web Inspector: new glyphs are visible on OS X 10.9 builds

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Brian Burg]

Per screenshot. The dashboard looks a little different too, though I can't pinpoint what changed. Maybe the font is different?

[Brian Burg]

Created attachment 236262 [details]
screenshot

[Radar WebKit Bug Importer]

<rdar://problem/17955582>

[Radar WebKit Bug Importer]

<rdar://problem/17955579>

[Brian Burg]

Changes:

- The chevrons to show full-height console
- Folder tree element icons
- the X dismiss glyph in Timeline sidebar panel

Another regression: in the resources sidebar panel, some text of main resource tree element and its download/reload glyphs turn black if you mousedown on the Timelines toolbar icon but don't mouseup. I think this is an :active style getting stuck or something?

[Brian Burg]

Created attachment 236263 [details]
tex color change

[Brian Burg]

Also, the glyphs for docking to the side or bottom are different.

[Timothy Hatcher]

Created attachment 236308 [details]
Patch

[Brian Burg]

I think the debugger play/pause button is also wrong (at least it looked weird when I hooked up Xcode debugger to the crash), but hard to tell with debugging broken. It may just be a render glitch as the process crashes?

[Joseph Pecoraro]

Comment on attachment 236308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236308&action=review

r=me, though you may want to check Brian's recent comment about Debugger buttons.

> Source/WebInspectorUI/UserInterface/Views/DataGrid.css:163
> -.data-grid td > div, .data-grid th > div {
> +.data-grid th > div,
> +.data-grid td > div {

I wonder when we should start forward and use :-webkit-any(...). This could be:

    .data-grid :-webkit-any(th, td) > div

I think we should stick with what we have now though =)

[Timothy Hatcher]

Created attachment 236343 [details]
Patch

[Timothy Hatcher]

Created attachment 236344 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 236344 [details]
Patch

Clearing flags on attachment: 236344

Committed r172379: <http://trac.webkit.org/changeset/172379>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.