Bug 135742 - REGRESSION(r172094): timeline views are blank after reloading in some situations
Summary: REGRESSION(r172094): timeline views are blank after reloading in some situations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-07 21:05 PDT by Brian Burg
Modified: 2014-08-08 11:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.08 KB, patch)
2014-08-07 23:41 PDT, Brian Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-08-07 21:05:44 PDT
Per Joe:

"1. Uncaught exception
showTimelineViewForType called with an undefined type from restoreFromCookie. You mentioned this should fix that problem:

-        if (selectedTimelineViewIdentifier === WebInspector.TimelineSidebarPanel.OverviewTimelineIdentifierCookieValue)
+        if (!selectedTimelineViewIdentifier || selectedTimelineViewIdentifier === WebInspector.TimelineSidebarPanel.OverviewTimelineIdentifierCookieValue)

2. Timeline views showing up completely blank

- reload a page with the inspector open => overview/specific views are blank
- make new selections in the timeline => views are still blank
- switch recordings => causes things to work, but you have to make a new time selection"
Comment 1 Radar WebKit Bug Importer 2014-08-07 21:05:55 PDT
<rdar://problem/17955556>
Comment 2 Brian Burg 2014-08-07 21:56:49 PDT
(1) is easy enough to fix.

For me, (2) manifests as the overview being shown for timeline 1 when timeline 2 is recording, and clicking on the timeline tree elements shows timelines for timeline 1 instead of 2. So it seems that we are showing timeline 1 by mistake, possibly right after showing the intended timeline. Without a debugger I can't be sure, so I'll try adding some logging.
Comment 3 Brian Burg 2014-08-07 23:41:37 PDT
Created attachment 236270 [details]
Patch
Comment 4 Brian Burg 2014-08-07 23:42:58 PDT
The patch fixes this issue, at least on my machine. Joe, let me know if you still run into the same problem.
Comment 5 WebKit Commit Bot 2014-08-08 00:06:10 PDT
Comment on attachment 236270 [details]
Patch

Clearing flags on attachment: 236270

Committed r172337: <http://trac.webkit.org/changeset/172337>
Comment 6 WebKit Commit Bot 2014-08-08 00:06:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Joseph Pecoraro 2014-08-08 11:20:11 PDT
This works better, but I'm seeing an uncaught exception and some other issues. I'll file bugs.

file:///Users/pecoraro/Build/Release/WebInspectorUI.framework/Resources/Protocol/InspectorBackend.js:173:30: CONSOLE ERROR Uncaught exception in inspector page while dispatching callback for command Page.getResourceTree:  TypeError: undefined is not a function (evaluating 'candidateObjectCookie.every(function valuesMatchForKey(key) {
                return candidateObjectCookie[key] === cookie[key];
            })')
file:///Users/pecoraro/Build/Release/WebInspectorUI.framework/Resources/Views/NavigationSidebarPanel.js:702:77: CONSOLE ERROR TypeError: undefined is not a function (evaluating 'candidateObjectCookie.every(function valuesMatchForKey(key) {
                return candidateObjectCookie[key] === cookie[key];
            })')
Comment 8 Joseph Pecoraro 2014-08-08 11:22:09 PDT
I'm guessing this issue was just a typo:

-            return candidateCookieKeys.length && candidateObjectCookie.every(function valuesMatchForKey(key) {
+            return candidateCookieKeys.length && candidateCookieKeys.every(function valuesMatchForKey(key) {