Bug 135741 - Web Inspector: Fix accidental always true comparison
Summary: Web Inspector: Fix accidental always true comparison
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2014-08-07 20:57 PDT by Joseph Pecoraro
Modified: 2014-08-07 23:57 PDT (History)
5 users (show)

See Also:

[PATCH] Proposed Fix (1.48 KB, patch)
2014-08-07 21:00 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-08-07 20:57:40 PDT
There is what looks like a typo in a comparison in OverviewTimelineView.js.

>     if (!this.currentTime !== oldCurrentTime) {
>         ^ -- why?

This looks like an accident causing the comparison to always be false. Removing it, things still behave as expected.

I know of no user impact from this change. Possible performance improvement?
Comment 1 Radar WebKit Bug Importer 2014-08-07 20:57:49 PDT
Comment 2 Joseph Pecoraro 2014-08-07 20:58:55 PDT
Err, this would cause the comparison to always be true*
Comment 3 Joseph Pecoraro 2014-08-07 21:00:17 PDT
Created attachment 236261 [details]
[PATCH] Proposed Fix
Comment 4 Timothy Hatcher 2014-08-07 23:23:37 PDT
Comment on attachment 236261 [details]
[PATCH] Proposed Fix

Did my TreeOutline fix inspire you to search for this needle in a haystack?
Comment 5 Timothy Hatcher 2014-08-07 23:24:45 PDT
Yes, this would be a performance improvement.
Comment 6 WebKit Commit Bot 2014-08-07 23:57:49 PDT
Comment on attachment 236261 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 236261

Committed r172336: <http://trac.webkit.org/changeset/172336>
Comment 7 WebKit Commit Bot 2014-08-07 23:57:51 PDT
All reviewed patches have been landed.  Closing bug.