RESOLVED FIXED 135736
HTML <sub> and <sup> elements do not work in some 64-bit builds 
https://bugs.webkit.org/show_bug.cgi?id=135736
Summary HTML <sub> and <sup> elements do not work in some 64-bit builds
Simon Fraser (smfr)
Reported 2014-08-07 17:03:55 PDT
HTML <sub> and <sup> elements do not work in some 64-bit builds
Attachments
Patch (4.67 KB, patch)
2014-08-07 17:11 PDT, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-08-07 17:11:48 PDT
Created attachment 236244 [details] Patch
Tim Horton
Comment 2 2014-08-07 17:15:04 PDT
Comment on attachment 236244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236244&action=review > Source/WebCore/rendering/VerticalPositionCache.h:36 > // Values for vertical alignment. does this comment still belong?
zalan
Comment 3 2014-08-07 17:28:21 PDT
Comment on attachment 236244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236244&action=review > Source/WebCore/rendering/RootInlineBox.cpp:942 > // Check the cache. > bool isRenderInline = renderer->isRenderInline(); > if (isRenderInline && !firstLine) { > - LayoutUnit verticalPosition = verticalPositionCache.get(renderer, baselineType()); > - if (verticalPosition != PositionUndefined) > - return verticalPosition; > + LayoutUnit cachedPosition; > + if (verticalPositionCache.get(renderer, baselineType(), cachedPosition)) > + return cachedPosition; > } > > LayoutUnit verticalPosition = 0; RootInlineBox::verticalPositionForBox is broken in so many different ways. :(
Simon Fraser (smfr)
Comment 4 2014-08-07 17:36:23 PDT
https://trac.webkit.org/r172317
Jon Lee
Comment 5 2014-08-18 11:20:09 PDT
<rdar://problem/17220564>
Note You need to log in before you can comment on or make changes to this bug.