Bug 135734 – make clean does not work in OpenSource, fails in WebKitLibraries

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Joseph Pecoraro]

* SUMMARY
`make clean` does not work because WebKitLibraries' Makefile is missing a "clean" target.

* STEPS TO REPRODUCE
shell> cd WebKitLibraries && make clean

[Joseph Pecoraro]

Created attachment 236241 [details]
[PATCH] Proposed Fix

[David Kilzer (:ddkilzer)]

Comment on attachment 236241 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=236241&action=review

r=me

> Tools/Scripts/copy-webkitlibraries-to-product-directory:311
> +    (system("rm", "-rf", "$productDir/usr/local/include/WebKitSystemInterface.h") == 0) or die;
> +    (system("rm", "-rf", "$productDir$llvmPrefix") == 0) or die;

I think you need to use the exitStatus() function (in VCSUtils.pm) to check the result of system() on Windows.

To put another way, I'm not sure if "system() == 0" will work on Windows.

[Joseph Pecoraro]

Comment on attachment 236241 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=236241&action=review

>> Tools/Scripts/copy-webkitlibraries-to-product-directory:311
>> +    (system("rm", "-rf", "$productDir$llvmPrefix") == 0) or die;
> 
> I think you need to use the exitStatus() function (in VCSUtils.pm) to check the result of system() on Windows.
> 
> To put another way, I'm not sure if "system() == 0" will work on Windows.

The rest of this file uses this idiom. Spoke on IRC lets land as is.

[WebKit Commit Bot]

Comment on attachment 236241 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 236241

Committed r172349: <http://trac.webkit.org/changeset/172349>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.