Bug 135731 – [Services with UI] Action menu does not appear if selection includes both text and an image

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Enrica Casucci]

* STEPS TO REPRODUCE
0. Install a text viewer extension
1. Load the Yelp page for Nihon Whisky Lounge in San Francisco - http://www.yelp.com/biz/nihon-whisky-lounge-san-francisco#query:nihon%20whiskey%20lounge
2. Select some text + a picture
3. Click on the arrow.

* RESULTS
Nothing happens.
Perhaps this is because a text viewer extension isn't considered valid for a selection containing an image, which would be fine, but in that case, I would expect the drop down arrow not to show up since there is no valid extension installed.

Expected
The arrow should not appear at all if there are no services that can handle combination of text and image.

<rdar://problem/17837491>

[Enrica Casucci]

Created attachment 236237 [details]
Patch

[Enrica Casucci]

Committed revision 172301.

[Tim Horton]

Comment on attachment 236237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236237&action=review

> Source/WebKit2/Shared/WebProcessCreationParameters.cpp:54
> +    , hasRichContentServices(false)

This needs to get filled in in WebContext::createNewWebProcess, but it doesn't! Will fix.

[Tim Horton]

Created attachment 236250 [details]
follow up patch

[Tim Horton]

Follow up landed in http://trac.webkit.org/changeset/172322.