Bug 135731 - [Services with UI] Action menu does not appear if selection includes both text and an image
Summary: [Services with UI] Action menu does not appear if selection includes both tex...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-07 15:30 PDT by Enrica Casucci
Modified: 2014-08-07 18:18 PDT (History)
1 user (show)

See Also:

Attachments
Patch (18.69 KB, patch)
2014-08-07 15:40 PDT, Enrica Casucci 		beidson: review+
Details | Formatted Diff | Diff
follow up patch (1.34 KB, patch)
2014-08-07 18:15 PDT, Tim Horton 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2014-08-07 15:30:07 PDT 
* STEPS TO REPRODUCE
0. Install a text viewer extension
1. Load the Yelp page for Nihon Whisky Lounge in San Francisco - http://www.yelp.com/biz/nihon-whisky-lounge-san-francisco#query:nihon%20whiskey%20lounge
2. Select some text + a picture
3. Click on the arrow.

* RESULTS
Nothing happens.
Perhaps this is because a text viewer extension isn't considered valid for a selection containing an image, which would be fine, but in that case, I would expect the drop down arrow not to show up since there is no valid extension installed.

Expected
The arrow should not appear at all if there are no services that can handle combination of text and image.

<rdar://problem/17837491>
Comment 1 Enrica Casucci 2014-08-07 15:40:53 PDT 
Created attachment 236237 [details]
Patch
Comment 2 Enrica Casucci 2014-08-07 16:09:16 PDT 
Committed revision 172301.
Comment 3 Tim Horton 2014-08-07 18:13:18 PDT 
Comment on attachment 236237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236237&action=review

> Source/WebKit2/Shared/WebProcessCreationParameters.cpp:54
> +    , hasRichContentServices(false)

This needs to get filled in in WebContext::createNewWebProcess, but it doesn't! Will fix.
Comment 4 Tim Horton 2014-08-07 18:15:48 PDT 
Created attachment 236250 [details]
follow up patch
Comment 5 Tim Horton 2014-08-07 18:18:55 PDT 
Follow up landed in http://trac.webkit.org/changeset/172322.