Bug 135729 - Get rid of SCRIPTED_SPEECH
Summary: Get rid of SCRIPTED_SPEECH
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-07 15:12 PDT by Benjamin Poulain
Modified: 2014-08-08 05:55 PDT (History)
16 users (show)

See Also:


Attachments
Patch (204.21 KB, patch)
2014-08-07 15:12 PDT, Benjamin Poulain
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-08-07 15:12:06 PDT
Get rid of SCRIPTED_SPEECH
Comment 1 Benjamin Poulain 2014-08-07 15:12:45 PDT
Created attachment 236232 [details]
Patch
Comment 2 Brent Fulgham 2014-08-07 16:59:09 PDT
Comment on attachment 236232 [details]
Patch

It seems like the WebCore.vcxproj needs to have these files removed. I can do that as a follow-up if you just want to land this.
Comment 3 Brent Fulgham 2014-08-07 17:33:01 PDT
Committed r172316: <http://trac.webkit.org/changeset/172316>
Comment 4 Brent Fulgham 2014-08-07 17:39:45 PDT
(In reply to comment #3)
> Committed r172316: <http://trac.webkit.org/changeset/172316>

Due to some Windows svn problems, I had to commit the LayoutTest changes in a second step:

> Committed r172318 <http://trac.webkit.org/changeset/172318>
Comment 5 Benjamin Poulain 2014-08-07 18:06:35 PDT
I am back... Thanks for landing the changes and fixing Windows!