We should minify Esprima. <rdar://problem/17879560>
Created attachment 236231 [details] Patch
Comment on attachment 236231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236231&action=review r=me > Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:99 > +open(ESLFILE, '<', $esprimaLicenseFile) or die "Unable to open $$esprimaLicenseFile: $!"; Nit: I think the $$ here is unexpected. > Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:105 > +$ESPRIMA_LICENSE .= " */\n"; We could make this block a function so we can share with the CodeMirror block. They are identical.
Created attachment 236239 [details] Patch
Comment on attachment 236239 [details] Patch Rejecting attachment 236239 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Volumes/Data/EWS/WebKit/Source/WebInspectorUI/UserInterface/External/Esprima/LICENSE: No such file or directory at /Volumes/Data/EWS/WebKit/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl line 45. Command /bin/sh failed with exit code 2 ** BUILD FAILED ** The following build commands failed: PhaseScriptExecution Copy\ User\ Interface\ Resources /Volumes/Data/EWS/WebKit/WebKitBuild/WebInspectorUI.build/Release/WebInspectorUI.build/Script-1C60FF1214E6D9AF006CD77D.sh (1 failure) Full output: http://webkit-queues.appspot.com/results/6215676310061056
(In reply to comment #4) > (From update of attachment 236239 [details]) > Rejecting attachment 236239 [details] from commit-queue. > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit > > Last 500 characters of output: > Volumes/Data/EWS/WebKit/Source/WebInspectorUI/UserInterface/External/Esprima/LICENSE: No such file or directory at /Volumes/Data/EWS/WebKit/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl line 45. This new patch is missing the LICENSE file.
Created attachment 236267 [details] Patch
Doh!
Comment on attachment 236267 [details] Patch Clearing flags on attachment: 236267 Committed r172331: <http://trac.webkit.org/changeset/172331>
All reviewed patches have been landed. Closing bug.