RESOLVED FIXED 135726
Web Inspector: add debugging flag to InspectorTest for unbuffered logging to stderr 
https://bugs.webkit.org/show_bug.cgi?id=135726
Summary Web Inspector: add debugging flag to InspectorTest for unbuffered logging to ...
Brian Burg
Reported 2014-08-07 14:59:28 PDT
.
Attachments
Patch (5.67 KB, patch)
2014-08-07 16:15 PDT, Brian Burg 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-08-07 14:59:42 PDT
<rdar://problem/17951314>
Brian Burg
Comment 2 2014-08-07 16:15:11 PDT
Created attachment 236238 [details] Patch
Brian Burg
Comment 3 2014-08-07 16:16:16 PDT
I decided to not guard this with !LOG_DISABLED, since debug builds often crash for dumb reasons and will additionally spew whatever WebCoreLogging you may have enabled. I also couldn't figure out how to conditionalize the method in InspectorFrontendHost.idl.
Timothy Hatcher
Comment 4 2014-08-07 16:34:01 PDT
Comment on attachment 236238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236238&action=review > Source/WebInspectorUI/UserInterface/Base/Test.js:138 > + if (InspectorTest.dumpMessagesToConsole && InspectorFrontendHost.unbufferedLog) Do we need to test InspectorFrontendHost.unbufferedLog?
Brian Burg
Comment 5 2014-08-07 20:01:21 PDT
(In reply to comment #4) > (From update of attachment 236238 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236238&action=review > > > Source/WebInspectorUI/UserInterface/Base/Test.js:138 > > + if (InspectorTest.dumpMessagesToConsole && InspectorFrontendHost.unbufferedLog) > > Do we need to test InspectorFrontendHost.unbufferedLog? I guess we do control who the InspectorFrontendHost really is during testing, so this could be removed.
Brian Burg
Comment 6 2014-08-08 13:22:14 PDT
Committed r172355: <http://trac.webkit.org/changeset/172355>
Note You need to log in before you can comment on or make changes to this bug.