Bug 135726 - Web Inspector: add debugging flag to InspectorTest for unbuffered logging to stderr
Summary: Web Inspector: add debugging flag to InspectorTest for unbuffered logging to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-07 14:59 PDT by Brian Burg
Modified: 2014-08-08 13:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.67 KB, patch)
2014-08-07 16:15 PDT, Brian Burg 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-08-07 14:59:28 PDT 
.
Comment 1 Radar WebKit Bug Importer 2014-08-07 14:59:42 PDT 
<rdar://problem/17951314>
Comment 2 Brian Burg 2014-08-07 16:15:11 PDT 
Created attachment 236238 [details]
Patch
Comment 3 Brian Burg 2014-08-07 16:16:16 PDT 
I decided to not guard this with !LOG_DISABLED, since debug builds often crash for dumb reasons and will additionally spew whatever WebCoreLogging you may have enabled. I also couldn't figure out how to conditionalize the method in InspectorFrontendHost.idl.
Comment 4 Timothy Hatcher 2014-08-07 16:34:01 PDT 
Comment on attachment 236238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236238&action=review

> Source/WebInspectorUI/UserInterface/Base/Test.js:138
> +    if (InspectorTest.dumpMessagesToConsole && InspectorFrontendHost.unbufferedLog)

Do we need to test InspectorFrontendHost.unbufferedLog?
Comment 5 Brian Burg 2014-08-07 20:01:21 PDT 
(In reply to comment #4)
> (From update of attachment 236238 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236238&action=review
> 
> > Source/WebInspectorUI/UserInterface/Base/Test.js:138
> > +    if (InspectorTest.dumpMessagesToConsole && InspectorFrontendHost.unbufferedLog)
> 
> Do we need to test InspectorFrontendHost.unbufferedLog?

I guess we do control who the InspectorFrontendHost really is during testing, so this could be removed.
Comment 6 Brian Burg 2014-08-08 13:22:14 PDT 
Committed r172355: <http://trac.webkit.org/changeset/172355>