Bug 135713 - [CMake] Drop the required version of CMake down to 2.8.8
Summary: [CMake] Drop the required version of CMake down to 2.8.8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-07 13:14 PDT by Zan Dobersek
Modified: 2015-05-12 18:12 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.31 KB, patch)
2014-08-07 13:22 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-08-07 13:14:50 PDT 
[CMake] Drop the required version of CMake down to 2.8.8
Comment 1 Zan Dobersek 2014-08-07 13:22:46 PDT 
Created attachment 236215 [details]
Patch
Comment 2 Alex Christensen 2014-08-07 13:59:47 PDT 
Comment on attachment 236215 [details]
Patch

r=me if this compiles successfully.  It would be a big hassle to require all the mac users to install a separate CMake
Comment 3 Zan Dobersek 2014-08-08 01:24:04 PDT 
Comment on attachment 236215 [details]
Patch

Clearing flags on attachment: 236215

Committed r172340: <http://trac.webkit.org/changeset/172340>
Comment 4 Zan Dobersek 2014-08-08 01:24:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Michael Catanzaro 2015-05-12 18:12:10 PDT 
(In reply to comment #2)
> r=me if this compiles successfully.  It would be a big hassle to require all
> the mac users to install a separate CMake

Is CMake 2.8.8 provided by OS X?

I was planning to revert this change, but did not know about this bug. I don't want to bump the CMake requirement if it would hinder your CMake efforts.

Context: https://lists.webkit.org/pipermail/webkit-dev/2015-May/027434.html