Bug 135712 - Fixed backgrounds don't paint in blurred inset areas
Summary: Fixed backgrounds don't paint in blurred inset areas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 135748
Blocks: 147049
  Show dependency treegraph
 
Reported: 2014-08-07 13:09 PDT by Beth Dakin
Modified: 2015-07-17 21:41 PDT (History)
7 users (show)

See Also:


Attachments
For review (1.88 KB, patch)
2014-08-07 13:17 PDT, Beth Dakin
no flags Details | Formatted Diff | Diff
Patch with test (11.07 KB, patch)
2014-08-07 14:34 PDT, Beth Dakin
no flags Details | Formatted Diff | Diff
Patch (20.89 KB, patch)
2014-08-07 15:12 PDT, Beth Dakin
simon.fraser: review+
Details | Formatted Diff | Diff
Patch (25.71 KB, patch)
2014-08-11 15:44 PDT, Beth Dakin
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-08-07 13:09:53 PDT
Background images that are background-attachment:fixed fail to paint in blurred inset areas.

<rdar://problem/17848141>
Comment 1 Beth Dakin 2014-08-07 13:17:31 PDT
Created attachment 236213 [details]
For review
Comment 2 Beth Dakin 2014-08-07 14:34:32 PDT
Created attachment 236225 [details]
Patch with test
Comment 3 Beth Dakin 2014-08-07 15:12:47 PDT
Created attachment 236233 [details]
Patch

The previous test did not work in wk2. Here's a new patch.
Comment 4 Beth Dakin 2014-08-07 15:25:50 PDT
Thanks Simon! http://trac.webkit.org/changeset/172291
Comment 5 WebKit Commit Bot 2014-08-07 23:37:39 PDT
Re-opened since this is blocked by bug 135748
Comment 6 Tim Horton 2014-08-07 23:45:59 PDT
With this patch, background-attachment: fixed on <body> with top content inset applied in WebKit2 ends up with a weird, large band of color at the top.
Comment 7 Beth Dakin 2014-08-11 15:44:13 PDT
Created attachment 236409 [details]
Patch
Comment 8 Beth Dakin 2014-08-11 15:45:30 PDT
This patch fixes the regression caused by the original patch and adds an additional test to confirm that.
Comment 9 Beth Dakin 2014-08-11 16:04:20 PDT
Thanks Simon! http://trac.webkit.org/changeset/172417