Bug 135700 - [EFL] Do not initialize g_type in WebProcessMain::platformInitialize()
Summary: [EFL] Do not initialize g_type in WebProcessMain::platformInitialize()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Grzegorz Czajkowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-07 05:34 PDT by Grzegorz Czajkowski
Modified: 2014-08-08 19:37 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2014-08-07 05:44 PDT, Grzegorz Czajkowski 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Czajkowski 2014-08-07 05:34:23 PDT 
Inspired by Jinwoo commit (r171788).

Glib since 2.36 itself initializes g_type_init.
Comment 1 Grzegorz Czajkowski 2014-08-07 05:44:17 PDT 
Created attachment 236186 [details]
Patch
Comment 2 Ryuan Choi 2014-08-08 05:12:50 PDT 
Comment on attachment 236186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236186&action=review

Looks good to me.

> Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:-101
> -#if !GLIB_CHECK_VERSION(2, 35, 0)
> -        g_type_init();
> -#endif
> -

Yes, we are using at least GLIB 2.38
Comment 3 Gyuyoung Kim 2014-08-08 19:04:09 PDT 
Comment on attachment 236186 [details]
Patch

r=me.
Comment 4 WebKit Commit Bot 2014-08-08 19:37:52 PDT 
Comment on attachment 236186 [details]
Patch

Clearing flags on attachment: 236186

Committed r172371: <http://trac.webkit.org/changeset/172371>
Comment 5 WebKit Commit Bot 2014-08-08 19:37:57 PDT 
All reviewed patches have been landed.  Closing bug.