Bug 135687 - [Win] Correct build errors when WebGL Disabled
Summary: [Win] Correct build errors when WebGL Disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-06 20:43 PDT by Brent Fulgham
Modified: 2014-08-07 09:25 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.06 KB, patch)
2014-08-06 20:45 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-08-06 20:43:06 PDT 
Attempting to build with the WebGL feature disabled revealed a few problems:

1. The 'DebugSuffix' target was attempting to build Cairo graphics files in addition to the CG files needed for this target.
2. Several files were including headers that themselves included ANGLE and other WebGL-specific files.
(a) platform/graphics/GLContext.cpp
(b) platform/graphics/GraphicsContext3DPrivate.cpp
(c) platform/graphics/opengl/GLPlatformContext.cpp
(d) platform/graphics/opengl/GLPlatformSurface.cpp

Although these files are configured to compile during non-WebGL builds, they are supposed to have appropriate compile guards so that no code is generated when the features are turned off.

Consequently, these files needed the "#if ENABLE(3D_GRAPHICS)" macro to be moved higher in the file (or added, in the case of the GLPlatformContext.cpp and GLPlatformSurface.cpp).
Comment 1 Brent Fulgham 2014-08-06 20:45:03 PDT 
Created attachment 236171 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2014-08-06 20:45:50 PDT 
<rdar://problem/17941465>
Comment 3 Brent Fulgham 2014-08-06 22:13:05 PDT 
Committed in r172202. <http://trac.webkit.org/changeset/172202>