Bug 135683 - Services overlay flashes a lot; should have some hysteresis before showing overlay
Summary: Services overlay flashes a lot; should have some hysteresis before showing ov...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-06 18:42 PDT by Tim Horton
Modified: 2014-08-06 19:58 PDT (History)
7 users (show)

See Also:


Attachments
patch (12.79 KB, patch)
2014-08-06 19:30 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff
patch (12.76 KB, patch)
2014-08-06 19:55 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-08-06 18:42:23 PDT
<rdar://problem/16878039>
Comment 1 Tim Horton 2014-08-06 19:30:42 PDT
Created attachment 236166 [details]
patch
Comment 2 Tim Horton 2014-08-06 19:31:45 PDT
Comment on attachment 236166 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236166&action=review

> Source/WebCore/dom/Document.cpp:3523
> +    /*ASSERT(m_inInvalidateNodeListAndCollectionCaches

err. ignore this part.
Comment 3 Simon Fraser (smfr) 2014-08-06 19:43:21 PDT
Comment on attachment 236166 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236166&action=review

> Source/WebKit2/WebProcess/WebPage/ServicesOverlayController.h:89
> +    bool mouseIsOverHighlight(DDHighlightRef, bool& mouseIsOverButton);

const method?

> Source/WebKit2/WebProcess/WebPage/ServicesOverlayController.h:90
> +    std::chrono::milliseconds remainingTimeUntilHighlightShouldBeShown();

const method?
Comment 4 Tim Horton 2014-08-06 19:55:30 PDT
Created attachment 236168 [details]
patch

Made Simon's changes; turned off hysteresis for telephone number highlights (they're already nice and stable); made it so that clicking where the highlight would be won't show the menu unless the timeout has passed.
Comment 5 Tim Horton 2014-08-06 19:58:48 PDT
http://trac.webkit.org/changeset/172200