I broke the cue comparison logic used to determine if newly encountered cues already exist in our set of cues for Generic cues (see Bug 135332 for why I did this).
<rdar://problem/17926802>
For Generic Cues (especially in these paint-on/roll-up modes) we want one set of ordering to decide which cues to render on screen first, and another for maintaining the time-ordered cue set for deciding whether a given cue is something we already know about.
Created attachment 236161 [details] Patch
Comment on attachment 236161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236161&action=review > Source/WebCore/html/track/TextTrackCueGeneric.cpp:218 > +bool TextTrackCueGeneric::isOrderedBeforeDuringDisplay(const TextTrackCue* that) const As we discussed on irc, maybe "isPositionedAbove" would be clearer?
(In reply to comment #4) > (From update of attachment 236161 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236161&action=review > > > Source/WebCore/html/track/TextTrackCueGeneric.cpp:218 > > +bool TextTrackCueGeneric::isOrderedBeforeDuringDisplay(const TextTrackCue* that) const > > As we discussed on irc, maybe "isPositionedAbove" would be clearer? Will do!
Committed r172213: <http://trac.webkit.org/changeset/172213>
(In reply to comment #6) > Committed r172213: <http://trac.webkit.org/changeset/172213> Let's keep an eye on the Mavericks test I reactivated. If they continue to fail we can turn them back off.