Bug 135672 - Get rid of INPUT_SPEECH
Summary: Get rid of INPUT_SPEECH
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-06 15:12 PDT by Benjamin Poulain
Modified: 2014-08-09 00:48 PDT (History)
4 users (show)

See Also:

Attachments
Patch (293.17 KB, patch)
2014-08-06 15:13 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (293.47 KB, patch)
2014-08-06 17:23 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (310.22 KB, patch)
2014-08-06 18:09 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-08-06 15:12:42 PDT 
Get rid of INPUT_SPEECH
Comment 1 Benjamin Poulain 2014-08-06 15:13:36 PDT 
Created attachment 236141 [details]
Patch
Comment 2 Benjamin Poulain 2014-08-06 17:23:31 PDT 
Created attachment 236157 [details]
Patch
Comment 3 Benjamin Poulain 2014-08-06 18:09:50 PDT 
Created attachment 236160 [details]
Patch
Comment 4 Benjamin Poulain 2014-08-07 14:04:41 PDT 
Comment on attachment 236160 [details]
Patch

Clearing flags on attachment: 236160

Committed r172259: <http://trac.webkit.org/changeset/172259>
Comment 5 Benjamin Poulain 2014-08-07 14:04:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Brent Fulgham 2014-08-07 16:53:34 PDT 
This broke the Windows build. I'll prep a change and check it in.
Comment 7 Brent Fulgham 2014-08-07 16:54:48 PDT 
Comment on attachment 236160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236160&action=review

> Tools/DumpRenderTree/TestRunner.h:-106
> -    void setMockSpeechInputDumpRect(bool flag);

These are still in win/TestRunnerWin.cpp
Comment 8 Simon Fraser (smfr) 2014-08-08 10:48:35 PDT 
Project fixup done in https://trac.webkit.org/r172345
Comment 9 Csaba Osztrogonác 2014-08-09 00:48:13 PDT 
(In reply to comment #6)
> This broke the Windows build. I'll prep a change and check it in.

and the buildfix landed in http://trac.webkit.org/changeset/172353