Bug 135669 - Document-relative overlays disappear after doing page-cache navigations
Summary: Document-relative overlays disappear after doing page-cache navigations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-06 13:59 PDT by Tim Horton
Modified: 2014-08-06 14:53 PDT (History)
5 users (show)

See Also:


Attachments
patch (2.57 KB, patch)
2014-08-06 14:08 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-08-06 13:59:07 PDT
<rdar://problem/17929171>
Comment 1 Tim Horton 2014-08-06 14:08:40 PDT
Created attachment 236132 [details]
patch
Comment 2 Simon Fraser (smfr) 2014-08-06 14:24:13 PDT
Comment on attachment 236132 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236132&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:3439
> +    Frame& frame = m_renderView.frameView().frame();
> +    Page* page = frame.page();
> +    if (!page)
> +        return;
> +
> +    if (GraphicsLayer* overlayLayer = page->chrome().client().documentOverlayLayerForFrame(frame))
> +        m_rootContentLayer->addChild(overlayLayer);

Just call appendOverlayLayers()?
Comment 3 Tim Horton 2014-08-06 14:53:26 PDT
http://trac.webkit.org/changeset/172179

As discussed, that's more work than it's worth.