WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
135669
Document-relative overlays disappear after doing page-cache navigations
https://bugs.webkit.org/show_bug.cgi?id=135669
Summary
Document-relative overlays disappear after doing page-cache navigations
Tim Horton
Reported
2014-08-06 13:59:07 PDT
<
rdar://problem/17929171
>
Attachments
patch
(2.57 KB, patch)
2014-08-06 14:08 PDT
,
Tim Horton
simon.fraser
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2014-08-06 14:08:40 PDT
Created
attachment 236132
[details]
patch
Simon Fraser (smfr)
Comment 2
2014-08-06 14:24:13 PDT
Comment on
attachment 236132
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=236132&action=review
> Source/WebCore/rendering/RenderLayerCompositor.cpp:3439 > + Frame& frame = m_renderView.frameView().frame(); > + Page* page = frame.page(); > + if (!page) > + return; > + > + if (GraphicsLayer* overlayLayer = page->chrome().client().documentOverlayLayerForFrame(frame)) > + m_rootContentLayer->addChild(overlayLayer);
Just call appendOverlayLayers()?
Tim Horton
Comment 3
2014-08-06 14:53:26 PDT
http://trac.webkit.org/changeset/172179
As discussed, that's more work than it's worth.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug