Bug 135658 - REGRESSION(r172094): tests fail because Inspector test harness does not include UIString
Summary: REGRESSION(r172094): tests fail because Inspector test harness does not inclu...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
Keywords: InRadar
Depends on:
Reported: 2014-08-06 10:41 PDT by Brian Burg
Modified: 2014-08-06 11:32 PDT (History)
4 users (show)

See Also:

Patch (1.50 KB, patch)
2014-08-06 11:01 PDT, Brian Burg
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-08-06 10:41:35 PDT
The timeline manager spins up during tests and makes a UIString for the first TimelineRecording's display name. But, localized strings are not currently included by Test.html.
Comment 1 Radar WebKit Bug Importer 2014-08-06 10:41:48 PDT
Comment 2 Brian Burg 2014-08-06 11:01:28 PDT
Created attachment 236117 [details]
Comment 3 Joseph Pecoraro 2014-08-06 11:10:44 PDT
Comment on attachment 236117 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=236117&action=review


> Source/WebInspectorUI/UserInterface/Base/Test.js:68
> +WebInspector.UIString = function(string) {
> +    // Don't localize strings when running tests.
> +    return string;
> +}

Style: Brace on new line
Nit: Comment doesn't seem necessary, this is straightforward.
Comment 4 Brian Burg 2014-08-06 11:32:54 PDT
Committed r172162: <http://trac.webkit.org/changeset/172162>