Bug 135651 - [iOS] QuickLook returns an invalid MIME type for some documents
Summary: [iOS] QuickLook returns an invalid MIME type for some documents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-06 08:59 PDT by Andy Estes
Modified: 2017-01-26 03:06 PST (History)
1 user (show)

See Also:

Attachments
Patch (4.72 KB, patch)
2014-08-06 09:10 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (1.73 KB, patch)
2014-08-06 10:44 PDT, Andy Estes 		ddkilzer: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2014-08-06 08:59:47 PDT 
[iOS] QuickLook returns an invalid MIME type for some documents
Comment 1 Andy Estes 2014-08-06 09:00:55 PDT 
<rdar://problem/17922339>
Comment 2 Andy Estes 2014-08-06 09:10:25 PDT 
Created attachment 236106 [details]
Patch
Comment 3 David Kilzer (:ddkilzer) 2014-08-06 09:46:13 PDT 
Comment on attachment 236106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236106&action=review

r=me

> Source/WebCore/platform/network/ios/QuickLook.mm:351
> +    NSURLResponse *previewResponse = _quickLookHandle->nsResponse();

Should we use a RetainPtr<> here, or are we certain this object was retained and autoreleased before being returned?
Comment 4 Andy Estes 2014-08-06 10:22:03 PDT 
(In reply to comment #3)
> (From update of attachment 236106 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236106&action=review
> 
> r=me

Thanks!

> 
> > Source/WebCore/platform/network/ios/QuickLook.mm:351
> > +    NSURLResponse *previewResponse = _quickLookHandle->nsResponse();
> 
> Should we use a RetainPtr<> here, or are we certain this object was retained and autoreleased before being returned?

QuickLookHandle is already storing the NSURLResponse returned by nsResponse() in a RetainPtr<>.
Comment 5 Andy Estes 2014-08-06 10:23:26 PDT 
Committed r172151: <http://trac.webkit.org/changeset/172151>
Comment 6 Andy Estes 2014-08-06 10:44:46 PDT 
Reopening to attach new patch.
Comment 7 Andy Estes 2014-08-06 10:44:47 PDT 
Created attachment 236111 [details]
Patch
Comment 8 David Kilzer (:ddkilzer) 2014-08-06 10:45:52 PDT 
Comment on attachment 236111 [details]
Patch

r=me
Comment 9 Andy Estes 2014-08-06 11:18:56 PDT 
Committed r172159: <http://trac.webkit.org/changeset/172159>