Bug 135643 - [EFL] Fix several warnings of doxygen
Summary: [EFL] Fix several warnings of doxygen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-06 02:56 PDT by Ryuan Choi
Modified: 2014-08-07 15:12 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.12 KB, patch)
2014-08-06 03:04 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (12.40 KB, patch)
2014-08-06 19:18 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2014-08-06 02:56:29 PDT 
SSIA
Comment 1 Ryuan Choi 2014-08-06 03:04:59 PDT 
Created attachment 236086 [details]
Patch
Comment 2 Grzegorz Czajkowski 2014-08-06 06:21:14 PDT 
Comment on attachment 236086 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236086&action=review

Looks nice!

> Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.h:106
> + * @param manager The cookie manager to update.

Nit: The -> the since it does not start a new sentence.
Comment 3 Ryuan Choi 2014-08-06 19:18:15 PDT 
Created attachment 236165 [details]
Patch
Comment 4 Ryuan Choi 2014-08-06 19:23:35 PDT 
(In reply to comment #2)
> (From update of attachment 236086 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236086&action=review
> 
> Looks nice!
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.h:106
> > + * @param manager The cookie manager to update.
> 
> Nit: The -> the since it does not start a new sentence.

Fixed.
Comment 5 Grzegorz Czajkowski 2014-08-07 00:27:40 PDT 
Thanks for fixing it. LGTM.
Comment 6 Gyuyoung Kim 2014-08-07 05:01:00 PDT 
Comment on attachment 236165 [details]
Patch

LGTM too.
Comment 7 WebKit Commit Bot 2014-08-07 15:12:12 PDT 
Comment on attachment 236165 [details]
Patch

Clearing flags on attachment: 236165

Committed r172284: <http://trac.webkit.org/changeset/172284>
Comment 8 WebKit Commit Bot 2014-08-07 15:12:19 PDT 
All reviewed patches have been landed.  Closing bug.