Bug 135633 - setCustomSwipeViews inside didChangeBackForwardList client callback is ignored
Summary: setCustomSwipeViews inside didChangeBackForwardList client callback is ignored
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Keywords: InRadar
Depends on:
Reported: 2014-08-05 19:21 PDT by Tim Horton
Modified: 2014-08-07 16:30 PDT (History)
3 users (show)

See Also:

patch (5.24 KB, patch)
2014-08-05 19:23 PDT, Tim Horton
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-08-05 19:21:06 PDT
WebKit clears the set of custom swipe views at the end of WebPageProxy::didChangeBackForwardList, *after* calling into the client. This means that if the client wants to setCustomSwipeViews in didChangeBackForwardList, it won't be respected.

Since there's only one client of this SPI, let's just stop clearing the list of custom swipe views in WebKit and leave that totally up to the client.
Comment 1 Radar WebKit Bug Importer 2014-08-05 19:21:15 PDT
Comment 2 Tim Horton 2014-08-05 19:23:33 PDT
Created attachment 236072 [details]
Comment 3 Tim Horton 2014-08-07 16:30:05 PDT