Bug 135625 – Add the ability to force text to render in white, not just black

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Peyton Randolph]

One of the paint behavior options is PaintBehaviorForceBlackText. I'd like to add a corresponding behavior for forcing white text.

[Peyton Randolph]

Created attachment 236057 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 236057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236057&action=review

> Source/WebCore/rendering/InlineTextBox.cpp:631
> +    const ShadowData* textShadow = (paintInfo.forceTextColor()) ? 0 : lineStyle.textShadow();

0 -> nullptr

> Source/WebCore/rendering/PaintPhase.h:63
> +    PaintBehaviorForceWhiteText = 1 << 6,

Please put this under PaintBehaviorForceBlackText and change the numbers.

> Source/WebCore/rendering/TextPaintStyle.cpp:142
> +        const ShadowData* shadow = paintInfo.forceTextColor() ? 0 : pseudoStyle->textShadow();

0 -> nullptr

[Peyton Randolph]

(In reply to comment #2)
> (From update of attachment 236057 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236057&action=review
> 
> > Source/WebCore/rendering/InlineTextBox.cpp:631
> > +    const ShadowData* textShadow = (paintInfo.forceTextColor()) ? 0 : lineStyle.textShadow();
> 
> 0 -> nullptr

Done.
> 
> > Source/WebCore/rendering/PaintPhase.h:63
> > +    PaintBehaviorForceWhiteText = 1 << 6,
> 
> Please put this under PaintBehaviorForceBlackText and change the numbers.

Done.
> 
> > Source/WebCore/rendering/TextPaintStyle.cpp:142
> > +        const ShadowData* shadow = paintInfo.forceTextColor() ? 0 : pseudoStyle->textShadow();
> 
> 0 -> nullptr

Done.

[Peyton Randolph]

Created attachment 236061 [details]
Patch

[Beth Dakin]

Comment on attachment 236061 [details]
Patch

Re-doing Simon's r+ and adding cq+

[Sam Weinig]

Instead of having both Black and white hard coded, should we instead just allow specifying a specific color?

[WebKit Commit Bot]

Comment on attachment 236061 [details]
Patch

Clearing flags on attachment: 236061

Committed r172110: <http://trac.webkit.org/changeset/172110>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.