Bug 135618 - Web Inspector: rename protocol methods for getting replay session/segment data
Summary: Web Inspector: rename protocol methods for getting replay session/segment data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-05 12:30 PDT by Brian Burg
Modified: 2014-08-05 14:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.86 KB, patch)
2014-08-05 12:59 PDT, Brian Burg 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-08-05 12:30:32 PDT 
The Replay.json protocol commands currently mention serialization but these methods aren't actually used to serialize/deserialize recordings. 

(In a future patch I plan to implement serialization/deserialization, which will hand a big JSON string to the backend and get a session or segment back, or vice-versa. The frontend may or may not be involved in that, but in any case, these names are misleading)
Comment 1 Radar WebKit Bug Importer 2014-08-05 12:30:54 PDT 
<rdar://problem/17920272>
Comment 2 Brian Burg 2014-08-05 12:59:09 PDT 
Created attachment 236044 [details]
Patch
Comment 3 Brian Burg 2014-08-05 14:28:55 PDT 
Committed r172080: <http://trac.webkit.org/changeset/172080>